Use GitHub Actions for continuous integration#2
Merged
aentinger merged 1 commit intoarduino-libraries:masterfrom Dec 16, 2019
per1234:CI
Merged
Use GitHub Actions for continuous integration#2aentinger merged 1 commit intoarduino-libraries:masterfrom per1234:CI
aentinger merged 1 commit intoarduino-libraries:masterfrom
per1234:CI
Conversation
Contributor
Author
|
It looks like GitHub won't run the actions submitted in a PR. You can see the successful run from my fork here: |
Contributor
|
@per1234 Thank you very much for adding CI to this repository. I have only one small request - can you please extend the |
On every push and pull request, all the example sketches will be compiled for MKR Zero and all files in the repository will be checked for misspelled words. The spell-check action found some misspelled words in the spiffs* files. Since this is an external dependency, fixing the true positives among these in this repository would lead to difficulty merging subsequent releases of spiffs. So I have added the true and false positives to extras/codespell-ignore-words-list.txt. I have submitted a PR upstream to fix the true positives. Once that is merged and pulled into this repo, the true positives may be removed from the list to avoid an increased possibility of false negatives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every push and pull request, all the example sketches will be compiled for MKR Zero and all files in the repository will be checked for misspelled words.
The
spell-checkaction found some misspelled words in the spiffs* files. Since this is an external dependency, fixing the true positives among these in this repository would lead to difficulty merging subsequent releases of spiffs. So I have added the true and false positives toextras/codespell-ignore-words-list.txt. I have submitted a PR upstream to fix the true positives: pellepl/spiffs#254. Once that is merged and pulled into this repo, the true positives may be removed from the list to avoid an increased possibility of false negatives.