ci: build warning fixes#534
Draft
pillo79 wants to merge 2 commits into
Draft
Conversation
The compile-sketches action runs the compilation with the 'all' warning level, which does not include the exceptions that usually are in place. We want to keep the full set of warnings for the user builds, but disable 'type-limits' and 'missing-field-initializers' in CI since they are always redundant.
- move read_resolution inside CONFIG_ADC guard to avoid warning about unused variable - move map64 outside of anonymous namespace because it can be used by other files (avoids warning about unused static function)
|
Memory usage change @ d2ff186
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash core warning count.
Related library PRs and TODOs: