Upgrade to Node 24#113
Conversation
|
Note that the markdown link check fails on a URL that exists, likely because npmjs.com have switched to stricter Cloudflare bot detection. I leave it to the maintainers to decide how to handle this. |
Node 20 actions are deprecated and GHA will refuse to run them in a few months. This change: - upgrades the action to Node 24 - upgrades actions it uses to versions on Node 24 - modifies how upload-artifact is used, as required by a breaking change to that action. Squashed from arduino#113 by Benjy Weinberger <benjyw>. Co-authored-by: Benjy Weinberger <benjyw@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
…s 20 to their latest Node-24 majors so every workflow that has an upstream fix stops emitting the deprecation warning. Each bump was audited for breaking changes and security posture before applying. Updates dorny/paths-filter to v4, docker/build-push-action to v7, docker/login-action to v4, docker/setup-buildx-action to v4, docker/setup-qemu-action to v4, peter-evans/find-comment to v4, peter-evans/create-or-update-comment to v5, amannn/action-semantic-pull-request to v6, Jimver/cuda-toolkit to v0.2.35, and softprops/action-gh-release to v3. arduino/setup-protoc is intentionally left at v3 because no Node-24 release exists upstream yet (open PR arduino/setup-protoc#113), so its single call site in tag_release.yaml will continue to emit the warning until that PR merges. After this change, a static scan of .github/ reports a single Node-20 action reference (down from 31 on the previous PR commit and 150 on main), and that reference is the unavoidable arduino/setup-protoc one.
|
Hey @benjyw, any update on this? :) |
I think this is up to @per1234 or someone else with write access in this repo. I have signed the CLA and the status badge finally shows this. The markdown link check is failing erroneously. For now you can fork the repo and reference your own branch on your fork? I don't want to guarantee that use benjyw/setup-protoc@fa4f90f will be around forever... |
|
It's looking like this repo is dead? 😦 |
|
Hey @benjyw, it's still warns about old deps: |
|
Actual fix: https://github.com/StackOverflowExcept1on/setup-protoc/tree/node24 # TODO: swicth back to `arduino/setup-protoc@v3` after it supports Node 24
- name: Install Protoc
uses: StackOverflowExcept1on/setup-protoc@node24
with:
repo-token: ${{ secrets.GITHUB_TOKEN }} |
I don't know about others, but I'm immediately hesitant to adopt an action from a user that owns repo |
|
I checked the delta from the original arduino repo and it seems fine so far, but I'd recommend at least something like this instead to make sure that continues to be the case: (@StackOverflowExcept1on for similar reasons you may want to consider hardcoding the hash for anthonyafgx/setup-task@chore/bump-node24 used in your repo) |
|
@rdamazio ok, make sense! |
It seems the original arduino/setup-protoc repo is dead (per arduino/setup-protoc#113), so adopting this version for now after having manually checked the delta.
|
Now with improved security (pin commit hash for here and for dependencies): https://github.com/StackOverflowExcept1on/setup-protoc/tree/node24. We use it at https://github.com/gear-tech/builds. # TODO: swicth back to `arduino/setup-protoc@v3` after it supports Node 24
- name: Install Protoc
uses: StackOverflowExcept1on/setup-protoc@3c8638272249639ffb4bc8571caff93ee0383579
with:
repo-token: ${{ secrets.GITHUB_TOKEN }} |
|
It would also be nice to fix this in my fork, but I don't know how yet. |
|
|
Node 20 actions are deprecated and GHA will
refuse to run them in a few months.
This change:
by a breaking change to that action.