Bump swift-transformers to 0.1.12#249
Closed
BrandonWeng wants to merge 3 commits intoargmaxinc:mainfrom
BrandonWeng:main
Closed
Bump swift-transformers to 0.1.12#249BrandonWeng wants to merge 3 commits intoargmaxinc:mainfrom BrandonWeng:main
BrandonWeng wants to merge 3 commits intoargmaxinc:mainfrom
BrandonWeng:main
Conversation
Contributor
|
@BrandonWeng Are you testing on the MLX branch in this repo? I'd be ok with merging this into that branch in the meantime to unblock you, still need to assess the impact of upgrading before merging with main. |
Author
|
No, I'm rooting for ya'll to get MLX working in this repo. (#200) Lets just close this for now, I can maintain my fork with this repo in the meantime. Its not a blocker for us |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into issues while trying to use MLX models locally.
mlx-community/Llama-3.2-1B-Instruct-bf16seems to require theSequencepost processor. https://github.com/huggingface/swift-transformers/blob/main/Sources/Tokenizers/PostProcessor.swift#L42MLX is still relatively new, so the package bump might not be warranted as it does introduce jinja as a dependency (guessing its because of the chat template). I will leave this here for posterity and in case other folks run into this issue