Updates the kvcache func in TextDecoder to work with Swift6#289
Open
jdowd7 wants to merge 1 commit intoargmaxinc:mainfrom
Open
Updates the kvcache func in TextDecoder to work with Swift6#289jdowd7 wants to merge 1 commit intoargmaxinc:mainfrom
jdowd7 wants to merge 1 commit intoargmaxinc:mainfrom
Conversation
Contributor
|
Thanks @jdowd7! Do you have any metrics on if there is a speed difference between the two implementations? |
Author
Not yet, will benchmark and report back when I get a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors this func to address the warning:
Tested in our application and its working as expected