Fix typo in suppressTokens variable name across multiple files#327
Closed
r0227n wants to merge 1 commit intoargmaxinc:mainfrom
Closed
Fix typo in suppressTokens variable name across multiple files#327r0227n wants to merge 1 commit intoargmaxinc:mainfrom
r0227n wants to merge 1 commit intoargmaxinc:mainfrom
Conversation
Contributor
|
There is currently already a PR for this #296. Unfortunately, this is a breaking change and would require us to deprecate the old spelling before fully switching over to retain backwards compatibility for the existing implementations. |
ghorzangasi
approved these changes
Sep 13, 2025
ghorzangasi
approved these changes
Sep 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a typo in the
suppressTokensproperty across multiple files in theWhisperKitcodebase. The property was previously misspelled assupressTokens. The changes ensure consistency in naming and improve code readability.Typo Fixes in
suppressTokensProperty:supressTokenstosuppressTokensin the documentation comments of theWhisperKitConfigclass. (Sources/WhisperKit/Core/Configurations.swift)DecodingOptionsstruct to use the correctedsuppressTokensproperty in its definition, initializer, and default assignment logic. (Sources/WhisperKit/Core/Configurations.swift) [1] [2] [3]supressTokenstosuppressTokensin theTextDecoderclass, ensuring compatibility with the updatedDecodingOptionsstruct. (Sources/WhisperKit/Core/TextDecoder.swift)CLIArgumentsstruct in the CLI module to reflect the corrected spelling in its property definition and help description. (Sources/WhisperKitCLI/CLIArguments.swift)TranscribeCLIstruct to use the correctedsuppressTokensproperty when mapping CLI arguments to decoding options. (Sources/WhisperKitCLI/TranscribeCLI.swift)[Copilot is generating a summary...]