Fix force-unwrap crashes in TextDecoder.decodeText during live transcription#417
Open
William-Laverty wants to merge 1 commit intoargmaxinc:mainfrom
Open
Fix force-unwrap crashes in TextDecoder.decodeText during live transcription#417William-Laverty wants to merge 1 commit intoargmaxinc:mainfrom
William-Laverty wants to merge 1 commit intoargmaxinc:mainfrom
Conversation
…dling Three force-unwraps in TextDecoder could cause crashes during repeated rapid transcription calls (e.g., live transcription preview at ~200ms intervals): 1. decoderInputs.initialPrompt.last! — crashes if initialPrompt is empty 2. decoderOutput.logits! (line 683) — crashes if logits is nil during language detection 3. decoderOutput.logits! (line 829) — crashes if logits is nil during main decoding loop All three are replaced with guard-let statements that throw descriptive WhisperError values, allowing callers to handle the error gracefully instead of crashing. Fixes argmaxinc#414
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces three force-unwraps in
TextDecoder.decodeTextthat cause crashes during repeated rapid transcription calls (e.g., live transcription preview at ~200ms intervals).Changes
Three force-unwraps replaced with
guard let+ descriptiveWhisperErrorthrows:decoderInputs.initialPrompt.last!(line 747) — crashes ifinitialPromptis emptydecoderOutput.logits!(line 683) — crashes if logits is nil during language detectiondecoderOutput.logits!(line 829) — crashes if logits is nil during main decoding loopAll three now throw
WhisperError.transcriptionFailedwith descriptive messages, allowing callers to handle errors gracefully instead of crashing.Fixes