This repository was archived by the owner on Jan 24, 2026. It is now read-only.
Fix tokenizers-sys to use HTTPS like other git clones#70
Merged
bpkeene merged 1 commit intoargmaxinc:mainfrom Jun 24, 2025
Merged
Fix tokenizers-sys to use HTTPS like other git clones#70bpkeene merged 1 commit intoargmaxinc:mainfrom
bpkeene merged 1 commit intoargmaxinc:mainfrom
Conversation
keith4ever
approved these changes
Jun 20, 2025
Contributor
keith4ever
left a comment
keith4ever
left a comment
There was a problem hiding this comment.
Looks good to me, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason the build script use SSH to clone the
tokenizers-sysrepo, whereas all other clones use HTTPS. This will break on environments where SSH is not configured. Switch to HTTPS to match the other repos.Type of Change
Test Plan
bash test/test_build_all.shand it ran successfullyChecklist