This repository was archived by the owner on Jan 24, 2026. It is now read-only.
Pin Qualcomm HF models to a working version#77
Merged
chen-argmax merged 5 commits intoargmaxinc:mainfrom Sep 26, 2025
Merged
Conversation
…le changes after that
…lcomm encoder/decoders
Collaborator
|
Hi @petewarden thanks very much for providing the fix! 👍 I have created this PR on top of yours, could you take a look and update this PR? |
Add revision to download interface and apply correct revision for Qualcomm encoder/decoders
Contributor
Author
|
Thanks @chen-argmax ! I've integrated your changes. |
chen-argmax
approved these changes
Sep 26, 2025
Collaborator
chen-argmax
left a comment
There was a problem hiding this comment.
verified locally, lgtm! 👍
Collaborator
|
@petewarden |
Fix detekt and format
chen-argmax
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It seems like Qualcomm changed the file and input/output names for their HuggingFace Whisper models in early June 2025. This causes the Android example app to crash, since it's pulling from the top of tree, but expects the models as they were before QC's changes. This PR adds an option to pin models to a particular revision, and sets those revisions to be the commits that were current in May 2025 for QC's tiny and base models. This solves the crash.
Type of Change
Test Plan
bash test/test_build_all.shand it ran successfullyChecklist