Skip to content
This repository was archived by the owner on Jan 24, 2026. It is now read-only.

Pin Qualcomm HF models to a working version#77

Merged
chen-argmax merged 5 commits intoargmaxinc:mainfrom
moonshine-ai:main
Sep 26, 2025
Merged

Pin Qualcomm HF models to a working version#77
chen-argmax merged 5 commits intoargmaxinc:mainfrom
moonshine-ai:main

Conversation

@petewarden
Copy link
Contributor

Description

It seems like Qualcomm changed the file and input/output names for their HuggingFace Whisper models in early June 2025. This causes the Android example app to crash, since it's pulling from the top of tree, but expects the models as they were before QC's changes. This PR adds an option to pin models to a particular revision, and sets those revisions to be the commits that were current in May 2025 for QC's tiny and base models. This solves the crash.

Type of Change

  • Bug fix 🐛
  • New feature 🚀
  • Refactor 🔄
  • Documentation update 📖
  • Other (please describe)

Test Plan

  • I have run bash test/test_build_all.sh and it ran successfully
  • I have tested this change on all relevant platforms.

Checklist

  • My code follows the project's style guidelines.
  • I have updated relevant documentation (if applicable).
  • I have added appropriate tests (if applicable).
  • I have self-reviewed my code before requesting review.

@chen-argmax chen-argmax self-requested a review September 25, 2025 20:56
@chen-argmax
Copy link
Collaborator

Hi @petewarden thanks very much for providing the fix! 👍
We are trying to have similar API interfaces for downloading from huggingface across Android and iOS, specifically exposing revision as a separate parameter to the downloading functions instead of adding it to Repo(reference from swift).

I have created this PR on top of yours, could you take a look and update this PR?

Add revision to download interface and apply correct revision for Qualcomm encoder/decoders
@petewarden
Copy link
Contributor Author

Thanks @chen-argmax ! I've integrated your changes.

Copy link
Collaborator

@chen-argmax chen-argmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally, lgtm! 👍

@chen-argmax
Copy link
Collaborator

chen-argmax commented Sep 26, 2025

@petewarden
oops the detekt failed, created another PR to fix it

@chen-argmax chen-argmax merged commit 2c347d4 into argmaxinc:main Sep 26, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants