[ATfE] Fix way_offset in A-profile cache invalidation#774
Open
voltur01 wants to merge 1 commit intoarm:arm-softwarefrom
Open
[ATfE] Fix way_offset in A-profile cache invalidation#774voltur01 wants to merge 1 commit intoarm:arm-softwarefrom
voltur01 wants to merge 1 commit intoarm:arm-softwarefrom
Conversation
In the code the ways variable is set to actual number of ways, e.g. 8. way_offset is calculated as the number of leading 0s, however 8 requires 4 bits to be encoded while the ways in the loop as encoded into 3 bits as values from 0 to 7. Thus way_offset should be the number of leading 0s for (ways - 1). Same logic was just implemented in M-profile version.
vhscampos
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the code the ways variable is set to actual number of ways, e.g. 8.
way_offset is calculated as the number of leading 0s, however 8 requires 4 bits to be encoded while the ways in the loop as encoded into 3 bits as values from 0 to 7.
Thus way_offset should be the number of leading 0s for (ways - 1).
Same logic was just implemented in M-profile version.