[ATfE] proflib.c sample workaround for LLVM libc#786
Merged
voltur01 merged 2 commits intoarm:arm-softwarefrom Mar 13, 2026
Merged
[ATfE] proflib.c sample workaround for LLVM libc#786voltur01 merged 2 commits intoarm:arm-softwarefrom
voltur01 merged 2 commits intoarm:arm-softwarefrom
Conversation
Provide a temporary implementation of missing file IO functions to allow running all samples including cpp-baremetal-semihosting-prof with LLVM libc.
vhscampos
previously approved these changes
Mar 12, 2026
Contributor
vhscampos
left a comment
vhscampos
left a comment
There was a problem hiding this comment.
LGTM but a minor suggestion
|
|
||
| size_t args[3]; | ||
| args[0] = (size_t)filename; | ||
| args[1] = (size_t)OPENMODE_W | OPENMODE_B; |
Contributor
There was a problem hiding this comment.
For better readability: (size_t)(OPENMODE_W | OPENMODE_B)
Contributor
Author
There was a problem hiding this comment.
Good suggestion, thanks - added.
vhscampos
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a temporary implementation of missing file IO functions to allow running all samples including cpp-baremetal-semihosting-prof with LLVM libc.