Conversation
JoeStech
requested changes
Feb 25, 2026
JoeStech
approved these changes
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for building and running MCP integration tests on both amd64 and arm64 GitHub runners, aiming to validate multi-architecture compatibility.
Changes:
- Run the integration test workflow as a matrix across
linux/amd64andlinux/arm64runners. - Add a pytest
--platformoption/fixture to let tests adapt behavior per platform (e.g., MCA tool gating). - Add a Docker ignore file intended to reduce Docker build context size.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/integration-tests.yml |
Runs build + integration tests on both amd64 and arm64 runners; builds platform-specific images. |
mcp-local/tests/test_mcp.py |
Accepts a platform fixture, adjusts platform-specific assertions/behavior. |
mcp-local/tests/constants.py |
Adds a default platform constant for tests/CLI defaulting. |
mcp-local/tests/conftest.py |
Introduces --platform option and platform fixture. |
mcp-local/.dockerignore |
Adds ignore rules intended to shrink Docker build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does a reviewer know it works?