build: add test coverage into pipeline + pre-commit#160
Open
dartanghan wants to merge 10 commits intoarm:mainfrom
Open
build: add test coverage into pipeline + pre-commit#160dartanghan wants to merge 10 commits intoarm:mainfrom
dartanghan wants to merge 10 commits intoarm:mainfrom
Conversation
Contributor
Author
|
Just noticed that pre-commit is also executed after the tests.
|
Contributor
Author
|
mpekatsoula
previously approved these changes
Mar 5, 2026
Contributor
mpekatsoula
left a comment
There was a problem hiding this comment.
Thanks @dartanghan this looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team!
I've added pytest-cov to our pipeline and pre-commit. Unfortunately we are under 40%, so I placed a threshold of 35% to start.
pytest --covcommandThe pytest-cov also tests the code, so I've replaced the
pytestbypytest --covTOTAL 2355 1431 39%
Required test coverage of 35% reached. Total coverage: 39.24%
I hope this addition can be useful.
PS: in pipeline only 20% is covered. Reduced the threshold