Skip to content

feat: improve remote port errors#335

Merged
yejseo01 merged 29 commits into
mainfrom
improve-remote-port-errors
Jul 16, 2026
Merged

feat: improve remote port errors#335
yejseo01 merged 29 commits into
mainfrom
improve-remote-port-errors

Conversation

@yejseo01

@yejseo01 yejseo01 commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Replaced curl with native TCP checks.
  • Added specific DNS, timeout, network, and exposure errors.
  • Added --skip-remote-port-check.
  • Suggests skipping only when the check is inconclusive.
  • Added coverage for the new behavior.
  • Support skipping of the port check through ENV variable

@yejseo01
yejseo01 requested a review from a team as a code owner July 13, 2026 14:53
@yejseo01 yejseo01 changed the title Improve remote port errors feat: improve remote port errors Jul 13, 2026
awphi
awphi reviewed Jul 14, 2026
View reviewed changes
Comment thread cmd/topo/deploy.go
Comment thread internal/deploy/deploy_test.go Outdated
Comment thread internal/deploy/deploy_test.go Outdated
Comment thread internal/ssh/config.go Outdated
Comment thread internal/ssh/config.go
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
awphi
awphi reviewed Jul 16, 2026
View reviewed changes
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go
awphi
awphi approved these changes Jul 16, 2026
View reviewed changes

@awphi awphi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Food for thought but not blocking!

Comment thread internal/ssh/ssh_tunnel.go Outdated
Comment thread internal/ssh/ssh_tunnel.go Outdated
@yejseo01
yejseo01 merged commit 2510269 into main Jul 16, 2026
5 checks passed
@yejseo01
yejseo01 deleted the improve-remote-port-errors branch July 16, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awphi awphi awphi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yejseo01 @awphi