Skip to content

feat: skip version checks when self-upgrade is disabled #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejseo01 merged 2 commits into from
Jul 17, 2026
Merged

feat: skip version checks when self-upgrade is disabled #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc4832
Skip version checks when self-upgrade is disabled
yejseo01 Jul 16, 2026
cfddf4a
Keep self-upgrade environment constant with upgrade command
yejseo01 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/topo/health.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ func init() {
}

func resolveSkipVersionChecks(cmd *cobra.Command) bool {
if env.IsVarTruthy(disableSelfUpgradeEnvVar) {
return true
}

if !cmd.Flags().Changed(skipVersionChecksFlag) {
return env.IsVarTruthy(skipVersionChecksEnvVar)
}
Expand Down
3 changes: 2 additions & 1 deletion cmd/topo/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
"github.com/spf13/cobra"
)

const disableSelfUpgradeEnvVar = "TOPO_DISABLE_SELF_UPGRADE"

var upgradeCmd = &cobra.Command{
Use: "upgrade",
Short: "Upgrade topo to the latest version",
Expand Down Expand Up @@ -55,7 +57,6 @@ func init() {
}

func isSelfUpgradeDisabled() bool {
const disableSelfUpgradeEnvVar = "TOPO_DISABLE_SELF_UPGRADE"
if env.IsVarTruthy(disableSelfUpgradeEnvVar) {
return true
}
Expand Down