fix: refresh projects when ancestor folders are deleted#343
Merged
Conversation
yejseo01
changed the title
yejseo01
marked this pull request as ready for review
July 16, 2026 15:51
yejseo01
changed the title
th3james
reviewed
Jul 17, 2026
| expect(model.projects).toStrictEqual(loaded(projects)); | ||
| }); | ||
|
|
||
| it('refreshes projects when a project ancestor is deleted', () => { |
Contributor
There was a problem hiding this comment.
I'm skeptical of the utility of these tests - there's a lot of very fragile mock building, and the test ends up primarily checking whether or not the mocks and the code are in sync rather than whether or not the product actually behaves the way we want.
The interesting behaviour here is actually isProjectAncestorDeleted, which is a nice pure function for which we could build a relatively expressive set of tests. You'd have to move it to a different module as it doesn't belong on the public API here.
th3james
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots
Screen.Recording.2026-07-16.at.16.27.57.mov