rockchip: Allow dt overlays that disable nodes#9396
rockchip: Allow dt overlays that disable nodes#9396igorpecovnik merged 1 commit intoarmbian:mainfrom
Conversation
CONFIG_ROCKCHIP_MINI_KERNEL implicitly sets CONFIG_DTC_OMIT_DISABLED=y CONFIG_DTC_OMIT_EMPTY=y this causes bundled devicetree overlays which set nodes to "disabled" to become noop. Disable these DTC_OMIT options to restore overlay disable functionality.
📝 WalkthroughWalkthroughTwo comment lines indicating unset DTC options are added to the Linux Rockchip vendor kernel configuration file. These are informational annotations with no functional impact on kernel configuration or behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
paolosabatino
left a comment
There was a problem hiding this comment.
Weird feature 🤔
Merge at will!
|
✅ This PR has been reviewed and approved — all set for merge! |
|
Vendor kernel never ceases to amaze. Nice find. |
Description
On armhf rockchip vendor, currently kernel-bundled devicetree overlays that set a node to
disabledare not compiled correctly (compiled file does not includedisableddirectives).CONFIG_ROCKCHIP_MINI_KERNELimplicitly setsthis causes bundled devicetree overlays which set nodes to "disabled" to become noop.
Disable these
DTC_OMIToptions to restore overlay disable functionality.Relates to:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
armsom-forge1using kernel from RK3506: Add overlay support / add overlays to disable Ethernet ifaces linux-rockchip#447armbian-configdisabledfunction correctly.Checklist:
Summary by CodeRabbit