Skip to content

rockchip: Allow dt overlays that disable nodes#9396

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
vidplace7:rockchip-fix-disable-dtbos
Feb 13, 2026
Merged

rockchip: Allow dt overlays that disable nodes#9396
igorpecovnik merged 1 commit intoarmbian:mainfrom
vidplace7:rockchip-fix-disable-dtbos

Conversation

@vidplace7
Copy link
Member

@vidplace7 vidplace7 commented Feb 13, 2026

Description

On armhf rockchip vendor, currently kernel-bundled devicetree overlays that set a node to disabled are not compiled correctly (compiled file does not include disabled directives).

CONFIG_ROCKCHIP_MINI_KERNEL implicitly sets

CONFIG_DTC_OMIT_DISABLED=y
CONFIG_DTC_OMIT_EMPTY=y

this causes bundled devicetree overlays which set nodes to "disabled" to become noop.

Disable these DTC_OMIT options to restore overlay disable functionality.

Relates to:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated kernel configuration file with clarification comments for device tree compiler settings. No functional changes.

CONFIG_ROCKCHIP_MINI_KERNEL implicitly sets
CONFIG_DTC_OMIT_DISABLED=y
CONFIG_DTC_OMIT_EMPTY=y

this causes bundled devicetree overlays which set nodes to "disabled" to become noop.

Disable these DTC_OMIT options to restore overlay disable functionality.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

Two comment lines indicating unset DTC options are added to the Linux Rockchip vendor kernel configuration file. These are informational annotations with no functional impact on kernel configuration or behavior.

Changes

Cohort / File(s) Summary
Kernel Configuration Comments
config/kernel/linux-rockchip-vendor.config
Added two comment lines documenting that DTC_OMIT_DISABLED and DTC_OMIT_EMPTY configuration options are not set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hops through configs with glee,
Comments added, plain to see,
DTC options marked "not set,"
Documentation, no regret!

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (2 files):

⚔️ config/kernel/linux-rockchip-vendor.config (content)
⚔️ extensions/ti-debpkgs.sh (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'rockchip: Allow dt overlays that disable nodes' directly and specifically describes the main functional change — enabling device-tree overlays to properly retain 'disabled' directives by disabling the DTC_OMIT options.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch rockchip-fix-disable-dtbos
  • Post resolved changes as copyable diffs in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... 02 Milestone: First quarter release labels Feb 13, 2026
Copy link
Contributor

@paolosabatino paolosabatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird feature 🤔
Merge at will!

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Feb 13, 2026
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Feb 13, 2026
@igorpecovnik igorpecovnik merged commit 95b7fa5 into armbian:main Feb 13, 2026
12 checks passed
@rpardini
Copy link
Member

Vendor kernel never ceases to amaze. Nice find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

4 participants