OrangePi 3 LTS: Update $board.conf file

[pyavitz]

Add legacy to KERNEL_TARGET var
Switch back to boot.scr
Add write_uboot_platform function
Fixup BOARD_NAME var

Merge after: #9381

Summary by CodeRabbit

• Updates
  • Extended Orange Pi 3 LTS kernel version support to include legacy releases alongside current and edge variants.
  • Enhanced board-level configuration and firmware handling for improved compatibility.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Orange Pi 3 LTS board configuration is updated with a standardized board name, expanded kernel target support to include legacy versions, removal of unused environment variables, and addition of U-Boot platform writing functionality.

Changes

Cohort / File(s)	Summary
Board Configuration config/boards/orangepi-lts.conf	Board name standardized to "OrangePi 3 LTS"; kernel targets expanded to support legacy, current, and edge versions; SRC_EXTLINUX and SRC_CMDLINE variables removed; write_uboot_platform function added to handle U-Boot binary writing with fsync.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A carrots path to boards so fine,
Orange Pi now in perfect line,
Legacy kernels join the dance,
U-Boot writes with swift advance,
Configuration hops along with glee! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change - updating the OrangePi 3 LTS board configuration file with multiple modifications including kernel targets, boot script, and u-boot platform function.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

config/boards/orangepi3-lts.conf (1)

22-24: Consider adding output suppression for consistency.

The dd command lacks output suppression, which will print transfer statistics to stderr during image builds and board-side u-boot updates. The standard sunxi implementation in sunxi_common.inc uses status=noxfer > /dev/null 2>&1.

Also note this implementation omits the zero-clearing step present in the standard sunxi family (dd if=/dev/zero of=$2 bs=1k count=1023 seek=1). If this is intentional for this board, no action needed.

Using conv=fsync is a good addition for ensuring data is flushed.

♻️ Optional: Add output suppression for cleaner logs

 			write_uboot_platform() {
-				dd if=$1/u-boot-sunxi-with-spl.bin of=$2 conv=fsync bs=1024 seek=8
+				dd if=$1/u-boot-sunxi-with-spl.bin of=$2 conv=fsync bs=1024 seek=8 status=noxfer > /dev/null 2>&1
 			}

Based on learnings: "In the Armbian build system, the write_uboot_platform() function implementations follow different patterns... The newer standard includes 'status=none' parameter in dd commands."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@config/boards/orangepi3-lts.conf` around lines 22 - 24, The
write_uboot_platform() implementation uses dd without output suppression and
omits the zero-clearing step; update the dd invocation in write_uboot_platform
to suppress progress output (e.g., add status=noxfer or status=none and redirect
stdout/stderr to /dev/null) so image builds and updates do not print transfer
stats, and if you want parity with sunxi_common.inc consider reinserting the
zero-clear step (the dd using /dev/zero with count=1023 seek=1) only if that
behavior is required for this board; locate the write_uboot_platform function
and modify the dd call accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@config/boards/orangepi3-lts.conf`:
- Around line 22-24: The write_uboot_platform() implementation uses dd without
output suppression and omits the zero-clearing step; update the dd invocation in
write_uboot_platform to suppress progress output (e.g., add status=noxfer or
status=none and redirect stdout/stderr to /dev/null) so image builds and updates
do not print transfer stats, and if you want parity with sunxi_common.inc
consider reinserting the zero-clear step (the dd using /dev/zero with count=1023
seek=1) only if that behavior is required for this board; locate the
write_uboot_platform function and modify the dd call accordingly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9dba00e9-6142-4176-80ff-f2e64fce531a

📥 Commits

Reviewing files that changed from the base of the PR and between 1b38e53 and 8c8aee4.

📒 Files selected for processing (1)

• config/boards/orangepi3-lts.conf

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!