Skip to content

kernel/tlsf: Add double-free detection in tlsf_freevec #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metaneutrons wants to merge 2 commits into
base: master
Choose a base branch
from
Open

kernel/tlsf: Add double-free detection in tlsf_freevec #777

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bee8c2
kernel/tlsf: Add double-free detection in tlsf_freevec
metaneutrons May 7, 2026
98eab58
Potential fix for pull request finding
metaneutrons May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions rom/kernel/tlsf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,9 +672,19 @@ void tlsf_freevec(struct MemHeaderExt * mhe, APTR ptr)

fb = MEM_TO_BHDR(ptr);

if (((ULONG)(IPTR)mhe->mhe_MemHeader.mh_First) & MEMF_SEM_PROTECTED)
BOOL sem_protected = !!(((ULONG)(IPTR)mhe->mhe_MemHeader.mh_First) & MEMF_SEM_PROTECTED);
if (sem_protected)
ObtainSemaphore((struct SignalSemaphore *)mhe->mhe_MemHeader.mh_Node.ln_Name);

/* Double-free detection (after semaphore for SMP safety) */
if (FREE_BLOCK(fb))
{
D(nbug("[Kernel:TLSF] DOUBLE FREE! ptr=%p size=%llu\n", ptr, (unsigned long long)GET_SIZE(fb)));
if (sem_protected)
ReleaseSemaphore((struct SignalSemaphore *)mhe->mhe_MemHeader.mh_Node.ln_Name);
return;
}

/* Mark block as free */
SET_FREE_BLOCK(fb);

Expand All @@ -700,8 +710,10 @@ void tlsf_freevec(struct MemHeaderExt * mhe, APTR ptr)
INSERT_FREE_BLOCK(tlsf, fb);
}

if (((ULONG)(IPTR)mhe->mhe_MemHeader.mh_First) & MEMF_SEM_PROTECTED)
if (sem_protected)
ReleaseSemaphore((struct SignalSemaphore *)mhe->mhe_MemHeader.mh_Node.ln_Name);


}

void tlsf_freemem(struct MemHeaderExt * mhe, APTR ptr, IPTR size)
Expand Down