Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @arpruss!
Following up on the issue #9, here is a proposition that might be good for other ADCTouchSensor users who would want to try the STM32duino (it's supported by ST so they have a lot of new architectures).
There is no default option for
ADCTOUCH_DIVIDER, so another even more inclusive option could be to use#elseinstead of my proposed#elif defined(ARDUINO_ARCH_STM32)(see here).Let me know if you prefer this 2nd option?
...or if there is anything I could do to make this pull request better?
Thanks again for this great lib!
Cedric :)
PS: It seems that Roger Clark suggests to use the stm32duino core now:
https://github.com/rogerclarkmelbourne/Arduino_STM32#background--support