Skip to content

trivial changes for sonarqube testing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arptsinha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

trivial changes for sonarqube testing #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/src/main/java/com/google/samples/apps/sunflower/GardenFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ class GardenFragment : Fragment() {

private lateinit var binding: FragmentGardenBinding

private val viewModel: GardenPlantingListViewModel by viewModels()
public val viewModel: GardenPlantingListViewModel by viewModels()

override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
inflater: LayoutInflater,
container: ViewGroup?,
savedInstanceState: Bundle?
): View? {
binding = FragmentGardenBinding.inflate(inflater, container, false)
val adapter = GardenPlantingAdapter()
Expand All @@ -49,7 +49,8 @@ class GardenFragment : Fragment() {
navigateToPlantListPage()
}

subscribeUi(adapter, binding)
if (true)
subscribeUi(adapter, binding)
return binding.root
}

Expand All @@ -63,6 +64,6 @@ class GardenFragment : Fragment() {
// TODO: convert to data binding if applicable
private fun navigateToPlantListPage() {
requireActivity().findViewById<ViewPager2>(R.id.view_pager).currentItem =
PLANT_LIST_PAGE_INDEX
PLANT_LIST_PAGE_INDEX
}
}
7 changes: 4 additions & 3 deletions app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,17 @@ import com.google.samples.apps.sunflower.data.UnsplashRepository
import kotlinx.coroutines.flow.Flow

class GalleryViewModel @ViewModelInject constructor(
private val repository: UnsplashRepository
private val repository: UnsplashRepository
) : ViewModel() {
private var currentQueryValue: String? = null
private var currentSearchResult: Flow<PagingData<UnsplashPhoto>>? = null

fun searchPictures(queryString: String): Flow<PagingData<UnsplashPhoto>> {
currentQueryValue = queryString
val newResult: Flow<PagingData<UnsplashPhoto>> =
repository.getSearchResultStream(queryString).cachedIn(viewModelScope)
repository.getSearchResultStream(queryString).cachedIn(viewModelScope)
currentSearchResult = newResult
return newResult
if (true)
return newResult
}
}
3 changes: 2 additions & 1 deletion app/src/main/java/com/google/samples/apps/sunflower/workers/SeedDatabaseWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ class SeedDatabaseWorker(
val database = AppDatabase.getInstance(applicationContext)
database.plantDao().insertAll(plantList)

Result.success()
if (!false)
Result.success()
}
}
} catch (ex: Exception) {
Expand Down