Conversation
Adds `dot_config/konsolequickcommandsconfig` with predefined commands for developer workflows (gh, git, go, flutter), system administration (chezmoi, systemd), and Gentoo package management (emerge). Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request adds a konsolequickcommandsconfig file containing a variety of shortcuts for development, system administration, and Gentoo package management. The review identifies several typos in command labels, incorrect wget parameters, and trailing newline characters in command strings that should be removed to ensure correct execution.
| tooltip= | ||
|
|
||
| [download][wget continue list.txt notify] | ||
| command=wget -I --continue --input list.txt --content-disposition --trust-server-names --retry-connrefused; notify-send "wget"\n |
There was a problem hiding this comment.
The wget command contains several issues:
-I(uppercase) is for--include-directoriesand requires an argument. You likely meant-ior--input-file.--inputis not a validwgetflag.- The trailing
\nwill likely be interpreted literally by the shell as an extra character or argument.
Suggested fix uses --input-file=list.txt and removes the trailing \n.
command=wget --continue --input-file=list.txt --content-disposition --trust-server-names --retry-connrefused; notify-send "wget"
There was a problem hiding this comment.
The
wgetcommand contains several issues:1. `-I` (uppercase) is for `--include-directories` and requires an argument. You likely meant `-i` or `--input-file`. 2. `--input` is not a valid `wget` flag. 3. The trailing `\n` will likely be interpreted literally by the shell as an extra character or argument.Suggested fix uses
--input-file=list.txtand removes the trailing\n.command=wget --continue --input-file=list.txt --content-disposition --trust-server-names --retry-connrefused; notify-send "wget"
@jules fix as above
There was a problem hiding this comment.
I have updated the wget command according to the suggested fix. Thanks!
| name=gh release push | ||
| tooltip= | ||
|
|
||
| [dev][git add ammend commit no edit tag release push tags and force push] |
There was a problem hiding this comment.
Typo in the section header: 'ammend' should be 'amend'.
[dev][git add amend commit no edit tag release push tags and force push]
|
|
||
| [dev][git add ammend commit no edit tag release push tags and force push] | ||
| command=git add . && git commit --amend --no-edit && git-tag-inc release && git push --tags && git push --force | ||
| name=git add ammend commit no edit tag release push tags and force push |
There was a problem hiding this comment.
Typo in the command name: 'ammend' should be 'amend'.
name=git add amend commit no edit tag release push tags and force push
| tooltip= | ||
|
|
||
| [gentoo][emerge sync world ask upgrade newuse with bdeps keepgoing notify] | ||
| command=sudo emerge --sync && sudo emerge -avuDNU --with-bdeps=y @world --keep-going=y; notify-send "Emerge world done"\n |
There was a problem hiding this comment.
Trailing \n in the command string will likely be interpreted literally by the shell. It should be removed unless the Konsole plugin specifically requires it for execution (which is inconsistent with other entries in this file).
command=sudo emerge --sync && sudo emerge -avuDNU --with-bdeps=y @world --keep-going=y; notify-send "Emerge world done"
There was a problem hiding this comment.
Trailing
\nin the command string will likely be interpreted literally by the shell. It should be removed unless the Konsole plugin specifically requires it for execution (which is inconsistent with other entries in this file).command=sudo emerge --sync && sudo emerge -avuDNU --with-bdeps=y @world --keep-going=y; notify-send "Emerge world done"
| tooltip= | ||
|
|
||
| [gentoo][emerge world ask deep new-use new upgarde keep going and notify afterwards] | ||
| command=sudo emerge @world -vauDNU --keep-going=y ; notify-send "Emerge world done"\n |
There was a problem hiding this comment.
Trailing
\nin the command string will likely be interpreted literally by the shell.command=sudo emerge @world -vauDNU --keep-going=y ; notify-send "Emerge world done"
|
|
||
| [gentoo][emerge world ask deep new-use new upgarde keep going and notify afterwards] | ||
| command=sudo emerge @world -vauDNU --keep-going=y ; notify-send "Emerge world done"\n | ||
| name=emerge world ask deep new-use new upgarde keep going and notify afterwards |
There was a problem hiding this comment.
Typo in the command name: 'upgarde' should be 'upgrade'.
name=emerge world ask deep new-use new upgrade keep going and notify afterwards
There was a problem hiding this comment.
Fixed the typo 'upgarde' to 'upgrade'.
Resolves the reported PR comment by using `--input-file=` instead of `-I --input` and removing the literal trailing newline which breaks shell parsing. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Changed 'upgarde' to 'upgrade' in the Gentoo emerge command name configuration as requested in PR review. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
Resolves issue by adding the requested
~/.config/konsolequickcommandsconfigpayload for managing Konsole's Quick Commands plugin.Added file:
dot_config/konsolequickcommandsconfigPR created automatically by Jules for task 3471236948531877642 started by @arran4