[codex] cache things-cli read state#10
Open
pdurlej wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
things-cliread commandshistory.Sync()call for read-only commandsTHINGS_CLI_CACHEfor overriding the cache file pathContext
Before this change, every read command rebuilt
memory.Statefromstart-index=0, andinitCLI()also fetched history items before dispatching the command. That made commands likelist,show,areas,projects, andtagspay a full-history cost on every invocation.The cache stores the aggregated
memory.Stateplus the last server index. On subsequent read commands, the CLI checks the current server index and applies only new history items to the cached state. Write commands still sync the history head before writing soancestor-indexstays valid.This branch is independent of the pagination fix in #6: before fetching a delta page, it seeds
history.LoadedServerIndexwith the cached cursor so the currentmainimplementation continues from the correct position.Validation
go test ./cmd/things-cli -count=1go test ./...