🛡️ Sentinel: [HIGH] Fix authorization bypass in API (ChangeAdminTOTP)

[arumes31]

🚨 Severity: HIGH
💡 Vulnerability: The ChangeAdminTOTP endpoint allowed any user with manage_admins permissions to reset the TOTP secret of the main configuration-driven admin account (GUIAdmin).
🎯 Impact: This authorization bypass could lead to a localized denial of service (lockout) or potential privilege escalation/account takeover of the primary system administrator account.
🔧 Fix: Added an explicit identity check in internal/api/admin_handlers.go to return a 403 Forbidden response if a user attempts to modify the GUIAdmin's TOTP secret via this endpoint, matching the protections already in place on other admin modification endpoints.
✅ Verification: Tested the API unit tests internally. Attempting to reset GUIAdmin TOTP will now return HTTP 403.

---

PR created automatically by Jules for task 284013288448449529 started by @arumes31

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6aeb0565-d04e-4788-af5f-c3e073477881

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-fix-totp-284013288448449529

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}