Open
Conversation
It's confusing if the project is simply called "Example", especially if you add the project as dependency to another project. Lets call it "QRCode" instead.
`DEBUG=1` is already set by default.
Actually, Xcode automatically did it.
blochberger
force-pushed
the
pr/macOS-support
branch
from
3533273 to
a1366de
Compare
Most of the code can be shared, except for the `UIKit` imports, which I conditionally replaced by `Cocoa` imports on macOS. Image handling is slightly different, as the `UI*` classes are not available on macOS. Due to the initializer of `NSImageView` not accepting an optional `NSImage` I refrained from adding a convenient initializer accepting a `QRCode`, where it is unclear if an image could be constructed.
blochberger
force-pushed
the
pr/macOS-support
branch
from
a1366de to
147d3a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a lot of commits but until commit 06c0ef4 it is mostly cleaning up the code in preparation.
Most of the code can be shared, except for the
UIKitimports, which I conditionally replaced byCocoaimports on macOS. Image handling is slightly different, as theUI*classes are not available on macOS.Due to the initializer of
NSImageViewnot accepting an optionalNSImageI refrained from adding a convenience initializer accepting aQRCode, where it is unclear if an image could be constructed.I'm not sure if it breaks the Travis CI, Carthage, Cocoapods, etc setups. I would appreciate if someone can test that.