Add options to save PNG and SVG snapshots at markers, override image dimensions, transparent background#103
Add options to save PNG and SVG snapshots at markers, override image dimensions, transparent background#103benw wants to merge 12 commits into
Conversation
struct Asciicast now provides Events instead of OutputEvents.
This disables the normal animated GIF output.
| .theme | ||
| .or_else(|| header.term_theme.map(Theme::Embedded)) | ||
| .clone() | ||
| .or_else(|| header.term_theme.clone().map(Theme::Embedded)) |
There was a problem hiding this comment.
Clones are needed because this is now accessing config and header through shared refs, previously it moved out of them.
benw
changed the title
benw
changed the title
benw
changed the title
|
Hey @benw, Thanks for the PR. I believe it's best to decouple frame selection from output format, and I've been thinking about how to tackle this for a while. I've been looking for a good generic and flexible solution for frame selection (#111 also attempted this), and I believe I found something that should work well: #116 - let me know what you think. Alternative output formats is definitely something I want to support, and that's something like to include in the following release (while the next one - 1.9 - will be about frame selection only I think). I have some ideas for this, will share soon. |
2 participants
Hi Marcin,
Thanks for this great tool! I'm using it to make slides for video, so I've added a few options:
--mode snapshot-markerswrites a PNG, SVG and .txt snapshot for each marker in the input, named according to the marker label.--widthand--heightoverride the output image dimensions.--transparent-backgroundto... y'know.This PR is intended to be easiest to review commit-by-commit. Please feel very welcome to decline this! Or ask for changes etc, feedback welcome. Thanks,
Ben.