refactor: read touch_update_defaults? from options instead of changeset context#701
Merged
zachdaniel merged 9 commits intoash-project:mainfrom Mar 2, 2026
Merged
Conversation
…onflict update_timestamp attributes (e.g. updated_at) were never included in the ON CONFLICT DO UPDATE SET clause because they have writable?: false and thus never appear in changeset.attributes. This ensures fields with update_defaults are always included when an upsert modifies fields. Closes ash-project#696
…et context Read the touch_update_defaults? flag from the bulk_create options map rather than from changeset context. Depends on ash-project/ash#2590 which adds touch_update_defaults? to the options passed to data layers. Only merge once that PR is merged and released.
Contributor
Author
|
@zachdaniel tests will pass once ash-project/ash#2590 is merged into ash |
7 tasks
zachdaniel
reviewed
Feb 26, 2026
lib/data_layer.ex
Outdated
| touch_update_defaults? = | ||
| Enum.at(changesets, 0).context[:data_layer][:touch_update_defaults?] != false | ||
| # Can be disabled via touch_update_defaults?: false option | ||
| touch_update_defaults? = Map.get(options, :touch_update_defaults?, true) |
Contributor
There was a problem hiding this comment.
I think it would be good to check both here so that its backwards compatible.
Contributor
|
Ash has been updated. Mind updating |
Contributor
|
Same for the |
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the touch_update_defaults? flag from the bulk_create options map
rather than from changeset context.
Depends on ash-project/ash#2590 which adds touch_update_defaults? to the
options passed to data layers. Only merge once that PR is merged and released.
Also support touch_update_defaults? option in non-bulk upsert path
Contributor checklist
Leave anything that you believe does not apply unchecked.