fix: --check false positive after disk round-trip#59
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Mar 9, 2026
Merged
Conversation
…mismatch Rewrite.Source.write/2 applies eof_newline/1 (String.trim_trailing + "\n") before File.write/2, but the generated content may not end with "\n". On subsequent syncs, the 1-byte trailing newline difference causes --check to report changes when nothing actually changed. Fix by comparing managed sections (trimmed) for SKILL.md files and trimmed content for reference files, so trailing whitespace differences from the disk round-trip are ignored.
zachdaniel
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix usage_rules.sync --checkreports false positives on a second run after a clean syncRewrite.Source.write/2applieseof_newline/1(String.trim_trailing/1+"\n") beforeFile.write/2, but generated content may not end with"\n". The 1-byte trailing newline diff causes--checkto detect changes when nothing actually changed.Test plan
simulate_disk_roundtriphelper that applies the sameeof_newlinetransform Rewrite uses on disk writes