Replace EmailSender polymorphic methods by a fluent API to build an email to be sent#111
Replace EmailSender polymorphic methods by a fluent API to build an email to be sent#111nakutahyali wants to merge 3 commits intoasiffermann:trunkfrom nakutahyali:email-builder
Conversation
…mail to be send #30 I created EmailBuilder class and refactored existing codes and tests for this. But i am not exacty sure what i did correct. Because I could not run the tests in my local.
Unit tests results 12 files 10 suites 3s ⏱️ For more details on these failures, see this check. Results for commit 4a5ef87. ♻️ This comment has been updated with latest results. |
|
@asiffermann Can u explain me why tests not passed? I refactored code and test both. They have builded without error. |
|
Hi @anilkutahyali, thanks, and great work! I have no time left tonight to check why the unit tests are failing, but I will check it tomorrow. Just to let you know, I will wait a little bit to merge this pull request (I marked it for the milestone 0.2.0) because I want to publish a first stable release that hasn't breaking changes compared to the legacy GeekLearning libraries. It is just missing basic documentation, which I will write this week. I want to ease the migration for the projects I work on that use those libraries, hope you'll understand 😊 |
asiffermann
changed the title
|
Thank you, i am going to wait for you to inform me. I saw the message you wrote late.. |
2 participants
I created EmailBuilder class and refactored existing codes and tests for this. But i am not exacty sure what i did correct. Because I could not run the tests in my local.
Fixes #30