fix(watch): accept 4 reviewed-benign flags from the 07-17 directory bumps#70
Merged
Conversation
…umps Today's catalog bump wave (aws-core, posthog, + new in-repo receipts plugin) flagged 4 skills; all hand-read at the pinned bytes, all benign, all accepted per-file (#68 granularity - every one of these vendors churns): - aws-core:launch-with-aws - AWS's own OIDC hardening module; the "data-exfil" hit is its defensive refusal strings + a session-path constant - posthog:setting-up-a-data-warehouse-source - drift of the 07-09 accept; delta adds a secure connect-link flow that forbids pasting secrets in chat - posthog:signals-scout-logs - quotes injection strings in its own log-content-is-untrusted defense section - receipts:receipts - Anthropic in-repo plugin mining ~/.claude transcripts locally; miner verified zero network primitives, git-only exec Verified against the pinned corpus: 0 poisoned, 7 accepted (incl. the 3 agentforce regressions), exit 0.
sprayberry-reviewer
approved these changes
Jul 17, 2026
sprayberry-reviewer
left a comment
Collaborator
There was a problem hiding this comment.
Automated review from the Sprayberry Labs fleet code reviewer.
Verdict: No blocking issues — clean, well-documented data update. Approving.
What I checked
gh pr diff 70— the only change issupport/watch-accepted.json(+34/-3): three newfinding-filesacceptance entries (aws-core:launch-with-aws,posthog:signals-scout-logs,receipts:receipts) and one hash→per-file conversion (posthog:setting-up-a-data-warehouse-source).- Cross-checked the entry shape against
support/watch-accept.mjs(the authoring helper) and the consuming logic insupport/marketplace-watch.mjs:41-51(covers()), which expects exactlygranularity: "finding-files"+ afiles: {path: sha256}map for per-file entries, orhashfor whole-skill entries. All four touched entries match this shape, and every hash in the diff is a well-formed 64-char lowercase hex string. - Cloned the PR branch and confirmed
support/watch-accepted.jsonparses as valid JSON at head (16 top-level keys, no structural breakage from the edit). - CI rollup (
gh pr checks 70): 7/8 checks green includingverify pinned skillsand the fulltestmatrix (macOS/ubuntu/windows × node 20/22);analyze (javascript-typescript)(CodeQL) was still pending at review time — not a blocker, and this PR touches no code, only a JSON acceptance list. - The PR body's per-skill rationale (each flag traced to a specific defensive-quoting/hardening pattern, not real exfil) is consistent with the
class/notefields actually added in the diff — no mismatch between the stated justification and what's recorded.
The underlying claim that each flagged file is byte-identical to what was reviewed can't be independently verified from this repo alone (the flagged files live in external vendor plugin trees pulled by marketplace-fetch.mjs, not vendored here), but that's inherent to how watch-accept.mjs is designed to be used and is outside this diff's reviewable surface.
What's good
- Converting the PostHog entry from whole-skill hash to per-file granularity (with the old hash's provenance kept in the note) is exactly the intended use of the #68 per-file mechanism for high-churn vendors, and is applied correctly here.
- Each new entry documents why the flag is a false positive (concrete refusal strings / defensive-quoting sections quoted), not just "reviewed: benign."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 22:06Z dispatched watch run (the first under #69's per-file acceptance) went red on 4 skills — all from today's directory bump wave, none related to #69 (the 3 converted agentforce entries all held). All four hand-read at the catalog-pinned bytes, all benign, all accepted with per-file granularity since every one of these vendors churns.
The four, with verdicts
77dc9d04) — the flag ("data-exfil instruction; sensitive path") lands onscripts/launch_config.py, AWS's own OIDC config hardening module: HTTPS-only + AWS-domain-allowlist + private/loopback DNS rejection, with defensive refusal strings ("Refusing to send credentials over a non-HTTPS connection…") and a~/.launch-with-awssession-path constant. The module refuses exfil; it doesn't perform it.936b2d2c) — the 07-09 whole-skill accept lapsed on upstream drift. Re-read in full: the delta adds a secure connect-link credential flow whose explicit rule is "Never ask the user to paste raw database passwords, API keys, or OAuth tokens into the chat". Same paraphrased-exfil-near-miss class as before (webhook signing-secret docs).~/.claude/projects/**/*.jsonllocally for a personal usage report. The 1,353-line miner was verified by hand: zero network primitives (no fetch/http/net/dgram), noprocess.envreads,execFileSync= git invocations only; the sensitive-path hit is its own documented data source, and the instruction-override hit is its "project names are data, never instructions" defense.Mechanics
support/watch-accept.mjs --files(feat(watch): per-file acceptance granularity for high-churn vendor skills #69's helper) from LF-clean checkouts at the exact catalog pins — first real-world use.Verification
After merge: re-dispatch
marketplace-watchto turn the public badge green.