FEAT: add prek,schema validation and GHA#25
Merged
maxulysse merged 9 commits intoaskimed:mainfrom Feb 13, 2026
Merged
Conversation
nvnieuwk
approved these changes
Feb 13, 2026
Collaborator
nvnieuwk
left a comment
nvnieuwk
left a comment
There was a problem hiding this comment.
Might also be a good idea to add a JSON schema validator in the future
mashehu
reviewed
Feb 13, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Collaborator
|
how about also a json-schema for that specific format? |
Collaborator
Author
I was already on it, @nvnieuwk asked me to |
mashehu
reviewed
Feb 13, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
mashehu
reviewed
Feb 13, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
mashehu
reviewed
Feb 13, 2026
mashehu
reviewed
Feb 13, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
maxulysse
changed the title
Collaborator
|
wow, great idea! thank you guys! |
Collaborator
Author
I made a mistake, I want to make sure it won't happen again 😆 |
Collaborator
that’s happened to me more than once as well :) |
mashehu
reviewed
Feb 13, 2026
mashehu
approved these changes
Feb 13, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Collaborator
|
Thank you guys! I really hope I will have more time soon to help out more actively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that #24 is never needed ever again
Adds: