Skip to content

Fix stale MCP tools list after failed connection retest in Add/Edit Instance dialog #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haiphucnguyen merged 1 commit into from
Jul 28, 2026
Merged

Fix stale MCP tools list after failed connection retest in Add/Edit Instance dialog #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions desktop-shared/src/main/kotlin/io/askimo/ui/mcp/AddMcpInstanceDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,8 @@ fun addMcpInstanceDialog(
secondaryButton(
onClick = {
dialogState.clearError()
testSuccess = null
availableTools = emptyList()
isTesting = true
scope.launch {
try {
Expand All @@ -416,10 +418,12 @@ fun addMcpInstanceDialog(
}
.onFailure { e ->
testSuccess = false
availableTools = emptyList()
dialogState.setError(e, "Failed to connect to MCP server. Check your configuration.")
}
} catch (e: Exception) {
testSuccess = false
availableTools = emptyList()
dialogState.setError(e, "Connection test failed")
} finally {
isTesting = false
Expand All @@ -433,6 +437,8 @@ fun addMcpInstanceDialog(
primaryButton(
onClick = {
dialogState.clearError()
testSuccess = null
availableTools = emptyList()
isTesting = true
scope.launch {
try {
Expand All @@ -447,10 +453,12 @@ fun addMcpInstanceDialog(
}
.onFailure { e ->
testSuccess = false
availableTools = emptyList()
dialogState.setError(e, "Failed to connect to MCP server. Check your configuration.")
}
} catch (e: Exception) {
testSuccess = false
availableTools = emptyList()
dialogState.setError(e, "Failed to save MCP instance")
} finally {
isTesting = false
Expand Down
Loading