Skip to content

[test] cover Q188 onchain tx decimal fields#30

Merged
HappySean2845 merged 1 commit into
mainfrom
codex/q188-onchain-tx-decimal-test
Jun 15, 2026
Merged

[test] cover Q188 onchain tx decimal fields#30
HappySean2845 merged 1 commit into
mainfrom
codex/q188-onchain-tx-decimal-test

Conversation

@HappySean2845

@HappySean2845 HappySean2845 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a Q188-specific regression test for onchain-tx hex quantity conversion.
  • Covers 0x1630d13 -> 23268627 and 0x0 -> zero native value.

Scope

This is regression coverage only. The runtime implementation that adds decimal companion fields already landed in v1.0.9 via the agent response views change.

For diver/runtime validation, the important dependency is that the rania image uses surf CLI 1.0.9+. Rania already merged that pin in cyberconnecthq/rania#434, and tag 0.0.78 contains it.

Validation

  • go test ./cli -run 'TestTransformResponseForCommandAdds(Q188BlockDecimal|OnchainTxDecimalFields)'
  • Note: go test ./... and full go test ./cli were interrupted after hanging without output; focused transform tests pass.

@HappySean2845 HappySean2845 changed the title [codex] cover Q188 onchain tx decimal fields [test] cover Q188 onchain tx decimal fields Jun 15, 2026
@HappySean2845
HappySean2845 marked this pull request as ready for review June 15, 2026 05:44
@HappySean2845
HappySean2845 merged commit de1409e into main Jun 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant