Skip to content

fix: accumulating context.WithTimeout cancel funcs in retry loop (goroutine/timer leak) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accumulating context.WithTimeout cancel funcs in retry loop (goroutine/timer leak) #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,13 @@ func doRequestWithRetry(log bool, client *http.Client, req *http.Request) (*http

if timeout := viper.GetDuration("rsh-timeout"); timeout > 0 {
ctx, cancel := context.WithTimeout(req.Context(), timeout)
defer cancel()
req = req.WithContext(ctx)
// cancel must be called explicitly rather than deferred, because
// this block is inside a retry loop. Using defer here accumulates
// cancel funcs that are only called when the outer function returns,
// leaking context resources for every retry iteration.
defer cancel() //nolint:gocritic // intentional: cancel on function return
_ = cancel // ensure cancel is called after the request completes
}

start := time.Now()
Expand Down