Fix staging sync base URL#38
Closed
ZhimaoL wants to merge 1 commit into
Closed
Conversation
* [FIX] sync surf API spec from configured base * fix(tests): build surf binary with windows extension * fix(cli): keep surf cache tests hermetic --------- Co-authored-by: HappySean <zhaoxiang2845@gmail.com>
Contributor
Author
|
Closing this because it is a generic staging sync-base-url fix, not the exchange endpoint skill/CLI integration work. Keeping the exchange task focused on OpenAPI-driven CLI discovery and surf skill guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surf syncrespectsSURF_API_BASE_URL/--surf-api-base-urlVerification
HOME=/tmp/surf-cli-stg-baseurl-test-home go test ./...go build -o /tmp/surf-stg-baseurl ./cmd/surfHOME=/tmp/surf-stg-baseurl-home SURF_API_BASE_URL=https://api.stg.ask.surf/gateway/v1 /tmp/surf-stg-baseurl sync/tmp/surf-stg-baseurl list-operations -g | rg "exchange-(coverage|candles)"/tmp/surf-stg-baseurl exchange-coverage --exchange bithumb --limit 2 --json/tmp/surf-stg-baseurl exchange-candles --exchange bithumb --pair BTC/KRW --interval 5m --limit 2 --json