Switch multi-tool execution from sequential to parallel with ThreadPoolExecutor#114
Closed
mlikasam-askui wants to merge 1 commit intomainfrom
Closed
Switch multi-tool execution from sequential to parallel with ThreadPoolExecutor#114mlikasam-askui wants to merge 1 commit intomainfrom
mlikasam-askui wants to merge 1 commit intomainfrom
Conversation
adi-wan-askui
suggested changes
Aug 11, 2025
Comment on lines
+168
to
+169
| if len(tool_use_content_blocks) == 0: | ||
| return None |
Contributor
There was a problem hiding this comment.
WDYT about removing this? ThreadPoolExecutor.map() and, therefore, ToolCollection.run() can handle empty list.
Contributor
Author
|
@adi-wan-askui Great catch! I only tested this with my specific use case and didn't encounter that issue. I'd suggest closing this PR since we can't use it as-is. Parallel tool usage doesn't necessarily mean the tool executions themselves can be parallelized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing, running the tools in parallel was up to 9 seconds faster than running them sequentially.
Number of tools: 10
Sequential run: 13.5814 seconds
Parallel (threaded) run: 4.2600 seconds