Skip to content

Fix/persistence in chat api#123

Merged
adi-wan-askui merged 11 commits intomainfrom
fix/persistence-in-chat-api
Aug 22, 2025
Merged

Fix/persistence in chat api#123
adi-wan-askui merged 11 commits intomainfrom
fix/persistence-in-chat-api

Conversation

@adi-wan-askui
Copy link
Contributor

No description provided.

@adi-wan-askui adi-wan-askui force-pushed the feat/mcp-server-support branch from 6986c16 to b4220ea Compare August 20, 2025 20:10
Base automatically changed from feat/mcp-server-support to main August 20, 2025 20:16
@adi-wan-askui adi-wan-askui force-pushed the fix/persistence-in-chat-api branch from c60150e to ab50761 Compare August 21, 2025 07:29
- save them into individual files instead of a single JSONL file
with exception of "assistants"
- more consistent with other services
- `fastmcp.Client` raises error if no MCP configs are available
- already move to bson.ObjectId to prepare move
  to MongoDB
- listing was not working
- made all services, routers, models as consistent as possible
- readd assistant endpoints
@adi-wan-askui adi-wan-askui force-pushed the fix/persistence-in-chat-api branch from ab50761 to 785667b Compare August 21, 2025 07:35
@adi-wan-askui adi-wan-askui marked this pull request as ready for review August 21, 2025 07:36
@danyalxahid-askui
Copy link
Contributor

Quick comments (Did not go super deep the the PR):

  • Do we also need a hub implementation to see the assistant? is it planned?
  • The base path changes so all the previous messages will be removed. Right? --> Breaking change and major version upgrade?
    -- Also with the workspace implementation
  • So now each message is saved as a seperate Json file? or a file is saved seperately.
    including images etc.
    --Do we need to change something inside the Hub?
    -- when returning the thread will it have all the files etc or files will get seperately via path and message_id?

@adi-wan-askui adi-wan-askui merged commit c518fc5 into main Aug 22, 2025
1 check passed
@adi-wan-askui adi-wan-askui deleted the fix/persistence-in-chat-api branch August 22, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants