fix(chat)!: hold mcp client sessions#140
Merged
adi-wan-askui merged 2 commits intomainfrom Sep 11, 2025
Merged
Conversation
- sessions are not immediately closed after each call to server but instead kept open as expected by mcp protocol - sessions initiated lazily - one session per client per workspace (across all chats in workspace) - add playwwright npx to default seeds --> requiring playwright - no update of mcp tools on server update or update of mcp configs --> restart of chat api required - tools with the same name override each other --> tool names need to be unique across all servers - no limitation on workspaces, mcp servers and tools, resources, prompts or open connections/sessions --> may lead to unexpected behavior in case of too many - mcp servers with the same name override each other --> names need to be unique - can easily be extended later to support holding mcp sessions across one run if it becomes possible to continue run with new message instead of creating new run
danyalxahid-askui
approved these changes
Sep 10, 2025
Contributor
danyalxahid-askui
left a comment
danyalxahid-askui
left a comment
There was a problem hiding this comment.
LGTM.
Nice to have this.
Question for the Roadmap:
- Do we intend to depreciate the Web agent (assistant) in future and instead use the playright mcp instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead kept open as expected by mcp protocol
--> restart of chat api required
tool names need to be unique across all servers
or open connections/sessions
--> may lead to unexpected behavior in case of too many
be unique
across one run if it becomes possible to continue run with new message
instead of creating new run