Skip to content

Refactor/replace hard coded agents with dynamic assistants #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adi-wan-askui merged 9 commits into from
Sep 11, 2025
Merged

Refactor/replace hard coded agents with dynamic assistants #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf65bbf
refactor(chat)!: replace hard-coded agents with dynamic assistants
adi-wan-askui Sep 5, 2025
3ee2718
chore(vscode/settings): switch from pylance to cursorpyright
adi-wan-askui Sep 8, 2025
fa3ff62
fix(mcp): creating mcp tools from chat api
adi-wan-askui Sep 8, 2025
85d2e24
fix(tools): using input schemas with references
adi-wan-askui Sep 8, 2025
c95793c
feat(chat): include metadata about current run inside system prompt
adi-wan-askui Sep 8, 2025
324f6ca
feat(chat): introduce orchestrator agent and fix testing agent
adi-wan-askui Sep 8, 2025
3d3e7f5
chore: fix linting and typing issues
adi-wan-askui Sep 8, 2025
ecd827e
chore: update pdm.lock
adi-wan-askui Sep 11, 2025
bce5bb6
refactor: prevent user from modifying global assistants and mcp configs
adi-wan-askui Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,15 @@
"python.testing.unittestEnabled": false,
"python.testing.pytestArgs": [
"tests"
]
],
"cursorpyright.analysis.autoImportCompletions": true,
"cursorpyright.analysis.autoSearchPaths": true,
"cursorpyright.analysis.diagnosticMode": "workspace",
"cursorpyright.analysis.extraPaths": [
"src",
"tests"
],
"cursorpyright.analysis.inlayHints.functionReturnTypes": true,
"cursorpyright.analysis.inlayHints.variableTypes": true,
"cursorpyright.analysis.typeCheckingMode": "strict"
}
8 changes: 0 additions & 8 deletions docs/chat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,14 +272,6 @@ curl -X GET "$BASE_URL/v1/assistants" \
"object": "assistant",
"created_at": 1755848144
},
{
"id": "asst_ge3tiojsga3dgnruge3di2u5ov36shedkcslxnmcb",
"name": "Human DemonstrationAgent",
"description": null,
"avatar": "data:image/svg+xml;base64,PHN2ZyAgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIgogIHdpZHRoPSIyNCIKICBoZWlnaHQ9IjI0IgogIHZpZXdCb3g9IjAgMCAyNCAyNCIKICBmaWxsPSJub25lIgogIHN0cm9rZT0iIzAwMCIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6ICNmZmY7IGJvcmRlci1yYWRpdXM6IDJweCIKICBzdHJva2Utd2lkdGg9IjIiCiAgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIgogIHN0cm9rZS1saW5lam9pbj0icm91bmQiCj4KICA8cGF0aCBkPSJNMTkgMjF2LTJhNCA0IDAgMCAwLTQtNEg5YTQgNCAwIDAgMC00IDR2MiIgLz4KICA8Y2lyY2xlIGN4PSIxMiIgY3k9IjciIHI9IjQiIC8+Cjwvc3ZnPgo=",
"object": "assistant",
"created_at": 1755848144
},
{
"id": "asst_ge3tiojsga3dgnruge3di2u5ov36shedkcslxnmca",
"name": "AskUI Vision Agent",
Expand Down
22 changes: 11 additions & 11 deletions pdm.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ android = [
"pure-python-adb>=0.3.0.dev0"
]
chat = [
"askui[android,pynput,web]",
"askui[android,web]",
"uvicorn>=0.34.3",
"anyio>=4.10.0",
]
Expand Down
4 changes: 4 additions & 0 deletions src/askui/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

__version__ = "0.15.1"

import os

os.environ["FASTMCP_EXPERIMENTAL_ENABLE_NEW_OPENAPI_PARSER"] = "true"

from .agent import VisionAgent
from .locators import Locator
from .models import (
Expand Down
7 changes: 6 additions & 1 deletion src/askui/chat/api/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
from askui.chat.api.mcp_clients.manager import McpServerConnectionError
from askui.chat.api.mcp_configs.dependencies import get_mcp_config_service
from askui.chat.api.mcp_configs.router import router as mcp_configs_router
from askui.chat.api.mcps.computer import mcp as computer_mcp
from askui.chat.api.mcp_servers.computer import mcp as computer_mcp
from askui.chat.api.mcp_servers.testing import mcp as testing_mcp
from askui.chat.api.mcp_servers.utility import mcp as utility_mcp
from askui.chat.api.messages.router import router as messages_router
from askui.chat.api.runs.router import router as runs_router
from askui.chat.api.threads.router import router as threads_router
Expand Down Expand Up @@ -57,8 +59,11 @@ async def lifespan(app: FastAPI) -> AsyncGenerator[None, None]: # noqa: ARG001
v1_router.include_router(health_router)
app.include_router(v1_router)


mcp = FastMCP.from_fastapi(app=app, name="AskUI Chat MCP")
mcp.mount(computer_mcp)
mcp.mount(testing_mcp)
mcp.mount(utility_mcp)
mcp_app = mcp.http_app("/sse", transport="sse")


Expand Down
2 changes: 1 addition & 1 deletion src/askui/chat/api/assistants/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def retrieve_assistant(
@router.post("/{assistant_id}")
def modify_assistant(
assistant_id: AssistantId,
askui_workspace: Annotated[WorkspaceId | None, Header()],
askui_workspace: Annotated[WorkspaceId, Header()],
params: AssistantModifyParams,
assistant_service: AssistantService = AssistantServiceDep,
) -> Assistant:
Expand Down
Loading