fix: add encoding='utf-8' to all file operations to prevent UnicodeEn…#213
Merged
programminx-askui merged 2 commits intomainfrom Dec 17, 2025
Merged
fix: add encoding='utf-8' to all file operations to prevent UnicodeEn…#213programminx-askui merged 2 commits intomainfrom
programminx-askui merged 2 commits intomainfrom
Conversation
danyalxahid-askui
approved these changes
Dec 17, 2025
Contributor
danyalxahid-askui
left a comment
There was a problem hiding this comment.
LGTM.
Can be merged after Checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes file reading and writing operations across the codebase to always specify
encoding="utf-8". Additionally, it updates the project's coding guidelines to reflect this requirement and introduces new Git best practices.File encoding standardization:
Path.read_text(),Path.write_text()) in multiple modules to explicitly specifyencoding="utf-8", ensuring proper handling of Unicode characters across platforms. [1] [2] [3] [4] [5] [6] [7] [8] [9]Development guidelines update:
.cursorrulesrequiringencoding="utf-8"to be specified for all file read and write operations.Git workflow improvements:
.cursorrulesto discourage the use ofgit add .and to require explicit file additions, as well as to enforce the use of conventional commit message formats.…codeError