Merged
Conversation
- track all types of function calls (fn, staticmethod, classmethod, method) - make it testable and test it - decouple processors (e.g., segment) from telemetry - add in-memory processor
… VisionAgent - exclude sensitive information
- Updated all instances of @telemetry.track_call to @telemetry.record_call across VisionAgent, AskUiControllerClient, and ModelRouter. - Enhanced type hints for methods to ensure consistency and clarity. - Removed unused analytics.py file and added context.py for better organization of telemetry context classes. - Adjusted telemetry settings to include new parameters for response and exception handling in recorded calls. - Updated tests to reflect changes in telemetry function tracking.
- machine id must be a valid uuid4 - user id necessary for proper user_identification - context only takes predefined fields --> move custom context to properties - use batch api by not setting queue size to 1
- remove commented out tests - improve internal documentation - add missing exports - rm cursorrules - fix too long lines
adi-wan-askui
force-pushed
the
setup-telemetry
branch
from
f68ec98 to
108141d
Compare
- temporary until we have more time to setup ci
programminx-askui
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.