Improve code quality by introducing/optimising coverage reporting, typechecking, formatting, linting etc.#46
Merged
adi-wan-askui merged 4 commits intomainfrom May 1, 2025
Merged
Conversation
- exclude some modules (type errors) in `pyproject.toml` until modules are touched again - validate `askui.models.askui.ai_element_utils.AiElement` when deserializing from json - fix `askui.models.askui.ai_element_utils.Rectangle` (`xmax` was falsely named `ymax`) - fix `askui.models.askui.ai_element_utils.AiElement.json_path` (was falsely named `metadata_path`) - require prompt parameter of `askui.locators.Prompt()` to have at least 1 character - handle `get()` not being answered by model or incorrectly answered by introducing and raising new exceptions: - `NoResponseToQueryError` - `UnexpectedResponseToQueryError` - fix authorization in `askui.tools.askui.askui_hub.AskUIHub` - make `askui.tools.askui.askui_controller` more robust, e.g., by checking if stub has been initialized before using it
- replace black and isort with ruff
- remove checks and fix all scripts as not all lint errors can be fixed at the moment
adi-wan-askui
force-pushed
the
static-code-analysis
branch
from
d9ecf03 to
a4495f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
askui.models.askui.ai_element_utils.AiElementwhendeserializing from json
askui.models.askui.ai_element_utils.Rectangle(
xmaxwas falsely namedymax)askui.models.askui.ai_element_utils.AiElement.json_path(was falsely named
metadata_path)askui.locators.Prompt()to have atleast 1 character
get()not being answered by model or incorrectly answeredby introducing and raising new exceptions:
NoResponseToQueryErrorUnexpectedResponseToQueryErroraskui.tools.askui.askui_hub.AskUIHubaskui.tools.askui.askui_controllermore robust, e.g., bychecking if stub has been initialized before using it