Merged
Conversation
…ut formats - run formatting before typechecking because formatting can, e.g., change where the `type: ignore` comments are placed
- raise `InvalidModelError` instead of missing credentials if model is not supported - raise `ValidationError` (missing credentials) if user specified model but credentials are missing instead of routing to different model using with credentials configured or raising invalid model error - raise `ValidationError` (missing credentials) if using default model but credentials are missing instead of raising invalid model error - intro custom `InvalidModelError` for unsupported models - expose underlying models of `ModelRouter` through constructor so consumers can override them (e.g. for testing) - make model clients, e.g., `ClaudeHandler`, `AskUiInferenceApi`, etc. more configurable moving their settings into `BaseSettings` subclass and exposing them through constructor
- track `VisionAgent.locate()` - fix url configuration for segment (url from settings not used) - fix test termination by using `shutdown` instead of `flush`, adding timeout and max retries - fix telemetry disabling in tests - allow resetting telemetry processors - add debugger config for tests
adi-wan-askui
changed the title
also: - add reporting for keyboard()
feat(agent): add repeat parameter to VisionAgent.keyboard()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidModelErrorinstead of missing credentials ifmodel is not supported
ValidationError(missing credentials) if userspecified model but credentials are missing instead of
routing to different model using with credentials configured or
raising invalid model error
ValidationError(missing credentials) if using default modelbut credentials are missing instead of raising invalid model error
InvalidModelErrorfor unsupported modelsModelRouterthrough constructor soconsumers can override them (e.g. for testing)
ClaudeHandler,AskUiInferenceApi, etc.more configurable moving their settings into
BaseSettingssubclassand exposing them through constructor
VisionAgent.locate()shutdowninstead offlush,adding timeout and max retries