Merged
Conversation
adi-wan-askui
requested review from
programminx-askui
and removed request for
programminx-askui
Contributor
Author
|
@programminx-askui Can you take a look at the README if you agree with the new API (to register custom models) and how it is documented in the README? |
programminx-askui
approved these changes
May 28, 2025
Collaborator
programminx-askui
left a comment
programminx-askui
left a comment
There was a problem hiding this comment.
I realy like it.
I'm only thinking about the renaming of models to GetModel, ActModel, LocateModel.
programminx-askui
requested changes
May 28, 2025
onur-askui
reviewed
May 30, 2025
onur-askui
reviewed
May 30, 2025
- new `models` parameter in `VisionAgent` constructor
- fix some typing issues (mypy) across codebase
- fix some examples in docstrings
BREAKING CHANGES:
- `model_router` parameter removed from `VisionAgent` constructor
--> replaced by `models` parameter
- no default routing to Anthropic models as a fallback to AskUI models
(routing only to "askui" if `model` parameter not set)
- raising `exceptions.ModelNotFoundError` and
`exceptions.ModelTypeMismatchError` that may be raised by
- `VisionAgent.act()`
- `VisionAgent.click()`
- `VisionAgent.get()`
- `VisionAgent.locate()`
- `VisionAgent.mouse_move()`
- also make examples in docs clearer
BREAKING CHANGE: - changed order of arguments of `VisionAgent.get()` to fix typing errors (`image` moved to last position)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content:
modelsparameter inVisionAgentconstructor to register modelsBREAKING CHANGES:
model_routerparameter removed fromVisionAgentconstructor--> replaced by
modelsparameter(routing only to "askui" if
modelparameter not set)exceptions.ModelNotFoundErrorandexceptions.ModelTypeMismatchErrorthat may be raised byVisionAgent.act()VisionAgent.click()VisionAgent.get()VisionAgent.locate()VisionAgent.mouse_move()