Merged
Conversation
- Updated model references in the documentation and codebase from `anthropic-claude-3-5-sonnet-20241022` to `claude-sonnet-4-20250514`. - Added support for `stop_reason` to the `BaseAgent` class to manage stop reasons and raise appropriate exceptions. - Added new exceptions `MaxTokensExceededError` and `ModelRefusalError` to handle specific model response scenarios via `stop_reason` on `act()`. - Added support for thinking and tool choice via `AskUiComputerAgentSettings` and `ClaudeComputerAgentSettings`. - Updated tests to reflect the new model references.
onur-askui
force-pushed
the
feat/introduce-claude-4
branch
from
b529d1a to
c71b89e
Compare
onur-askui
commented
Jun 25, 2025
adi-wan-askui
suggested changes
Jun 25, 2025
Contributor
adi-wan-askui
left a comment
adi-wan-askui
left a comment
There was a problem hiding this comment.
In general, good job. Looking forward to Claude 4 and thinking etc. support :)
… tool_choice initialization to use a default_factory
…r response validation
adi-wan-askui
approved these changes
Jun 26, 2025
onur-askui
commented
Jun 26, 2025
- no error thrown in telemetry because of serialization hiding other exceptions - forward body of httpx.HTTPStatusError as ValueError
- otherwise validation fails - allows retrying requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
anthropic-claude-3-5-sonnet-20241022toclaude-sonnet-4-20250514.stop_reasonto theBaseAgentclass to manage stop reasons and raise appropriate exceptions.MaxTokensExceededErrorandModelRefusalErrorto handle specific model response scenarios viastop_reasononact().AskUiComputerAgentSettingsandClaudeComputerAgentSettings.