refactor!: make agents more composable#86
Merged
adi-wan-askui merged 2 commits intomainfrom Jul 10, 2025
Merged
Conversation
fe9e831 to
978f472
Compare
1ba0865 to
743ae78
Compare
- add `NullReporter` and `NULL_REPORTER` to `askui.reporting` - make Claude 4 available to `AndroidVisionAgent` - extract common base class `AgentBase` from `VisionAgent` and `AndroidVisionAgent` - make all settings for llm apis (messages / chat completions / responses) and agents configurable through environment variables BREAKING CHANGE: - remove `exceptions.AskUiApiError` and `AskUiApiRequestFailedError` (unused) - remove old ways of configuring (env vars and `*Settings` classes) Inference and Anthropic APIs / models except `ASKUI_TOKEN`, `ASKUI_WORKSPACE_ID` and `ASKUI_INFERENCE_ENDPOINT`, and `ANTHROPIC_API_KEY` (still work as before) - extend `ActModel.act` by 2 new parameters `tools` and `settings`
- remove global settings again - make settings more local or pass them through param - make authorization settings optional
48330e1 to
5b3f9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullReporterandNULL_REPORTERtoaskui.reportingAndroidVisionAgentAgentBasefromVisionAgentandAndroidVisionAgentAgentBase.act()BREAKING CHANGE:
exceptions.AskUiApiErrorandAskUiApiRequestFailedError(unused)
*Settingsclasses)Inference and Anthropic APIs / models except
ASKUI_TOKEN,ASKUI_WORKSPACE_IDandASKUI_INFERENCE_ENDPOINT,and
ANTHROPIC_API_KEY(still work as before)ActModel.actby 2 new parameterstoolsandsettings