Merged
Conversation
onur-askui
force-pushed
the
feat/update-controller-grpc
branch
from
0b14614 to
2329387
Compare
adi-wan-askui
suggested changes
Jul 18, 2025
Contributor
adi-wan-askui
left a comment
adi-wan-askui
left a comment
There was a problem hiding this comment.
Nice work :) I particularly like
- the tests. Really nice and easy to read and test that every controller method does not fail
- the thorough documentation
- how consistent it is with existent patterns
- that we now have the proto included and clear separation from generated code and proto
- the generation script persisted
Commented on some things where I would still do something or where I just wanted to share my current thoughts
onur-askui
force-pushed
the
feat/update-controller-grpc
branch
from
89f51e7 to
fed591c
Compare
onur-askui
force-pushed
the
feat/update-controller-grpc
branch
from
fed591c to
6fc726b
Compare
adi-wan-askui
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.