Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89c07f4c00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| outputs = [out], | ||
| inputs = [src], | ||
| tools = [coreutils.bin], | ||
| command = "{coreutils} hashsum --{algorithm} {src} > {out}".format( |
There was a problem hiding this comment.
This now invokes hashsum with src.path, which causes the generated .md5/.sha1/.sha256 files to record Bazel output paths (for example bazel-out/...) rather than just the artifact basename. In this repo’s release flow, multi_platform_rust_binaries outputs are later flattened into a destination directory by bazel/release/create_release.sh, so the checksum files no longer reference files that exist in the published bundle and *sum -c verification fails for users. Preserve the previous behavior by hashing from the source directory (or otherwise emitting only the basename in checksum lines).
Useful? React with 👍 / 👎.
1 participant
Pre-factored out of #937