feat: starbuf-derive service macro, gRPC remote execution proto, and ActionCache client in AXL#941
feat: starbuf-derive service macro, gRPC remote execution proto, and ActionCache client in AXL#941
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eedc6dadc7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ActionCache client in AXL Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All four integer-constructor branches (optional scalar, repeated scalar, plain int32/uint32, plain int64/uint64) were calling <i32 as UnpackValue>::unpack_value and casting with `as _`. This rejects or silently truncates any value outside i32 range before the cast, so fields like Digest.size_bytes > 2 GiB and any uint32 > 2^31-1 would fail or produce wrong results. Switch to <i64 as UnpackValue>::unpack_value for all non-enum integer fields; starlark-rust implements UnpackValue for i64 and handles the full 64-bit range. Enum fields stay on i32 since proto enum values are always small. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thesayyn
force-pushed
the
grpc-remote-cache
branch
from
c6ed876 to
13bb6f7
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b49d7aa4af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Changes are visible to end-users: yes
Support Remote Cache client in AXL
Test plan