Conversation
Tests for the ctx.http().get() API introduced in the axel-f branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
thesayyn
force-pushed
the
axel-f-axl-tests
branch
from
7d9c4ac to
ab8f022
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d9c4ac0e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -261,11 +263,11 @@ impl DiskStore { | |||
| let dep_path = self.dep_path(dep.name()); | |||
There was a problem hiding this comment.
expand_store iterates all.values() directly, but that order is later used to build module_configs and apply use_config functions in sequence (main.rs loops module_configs and appends to scoped_configs). Because HashMap iteration order is process-randomized, two dependencies that both write the same fragment/task settings can win in different orders across runs, producing nondeterministic command behavior and flaky CI outcomes. Sort deps (for example by module name) before pushing into module_roots.
Useful? React with 👍 / 👎.
| "list" => { | ||
| let items: Vec<Value<'v>> = value.iterate(heap)?.collect(); | ||
| Ok(heap.alloc(AllocList(items))) |
There was a problem hiding this comment.
This helper only copies the outer list/dict container, so nested mutable defaults are still shared across fragment instances. For example, attr(list[list[str]], [[]]) produces a new outer list but reuses the same inner list object, so mutating one instance leaks into others. That contradicts the documented deep-copy behavior and can cause cross-task configuration bleed.
Useful? React with 👍 / 👎.
1 participant
Add some tests for http.post
Changes are visible to end-users: no
Test plan